This repository has been archived by the owner on Nov 15, 2017. It is now read-only.
rename sample files once unzipped #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertiful
suggested changes
Jun 16, 2017
src/commands/theme.js
Outdated
| @@ -81,6 +81,12 @@ export default function(program) { | |||
|
|
|||
| return null; | |||
| }) | |||
| .then(() => { | |||
| renameFile(join(root, 'config-sample.yml'), join(root, 'config.yml')); | |||
| renameFile(join(root, '.gitignore-sample', join(root, '.gitignore'); | |||
src/utils.js
Outdated
| * @param {string} target - The renamed path of the file. | ||
| */ | ||
| export function renameFile(current, target) { | ||
| rename(current, target, (err) => { |
There was a problem hiding this comment.
Should we be wrapping this in return new Promise((resolve, reject) => {});?
src/utils.js
Outdated
| export function renameFile(current, target) { | ||
| rename(current, target, (err) => { | ||
| if (err) { | ||
| throw err; |
There was a problem hiding this comment.
If so, reject(err) here. And resolve() outside of the condition.
|
New project... that fyre. 🔥 |
NathanPJF
commented
Jun 16, 2017
src/commands/theme.js
Outdated
| @@ -89,7 +89,6 @@ export default function(program) { | |||
| ]; | |||
|
|
|||
| function renamePromiseFactory({oldFile, newFile, dir}) { | |||
| console.log(` Renaming ${oldFile} to ${newFile}...`); | |||
There was a problem hiding this comment.
Decided I didn't like the message after it said "you're done".
bertiful
approved these changes
Jun 19, 2017
| {oldFile: '.gitignore-sample', newFile: '.gitignore', dir: root}, | ||
| ]; | ||
|
|
||
| function renamePromiseFactory({oldFile, newFile, dir}) { |
There was a problem hiding this comment.
Thanks for this ES6 lesson 🥇
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Companion piece to this PR in
slate: Shopify/slate#179The idea: After running
slate theme, you are given an unzippedslate-src.zipplus two filesconfig-sampleand.gitignore-sample. Let's save the manual effort of renaming both these files when you start off.Checklist
For contributors:
For maintainers:
package.jsonversion in a separate PR, if applicable.Considerations: