Add i18n locale param support #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No idea whats up with CI errors, they have nothing to do with this PR. |
|
@SebastianSzturo Rebase this PR on master and tests should be 👌 Once you do, follow the instructions here to release |
7614516 to
f89191c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports the new
localeparam that is passed into embedded apps (https://github.com/Shopify/shopify/pull/112729) and automatically sets theI18n.localeif language is supported by the rails configuration.Also adds translations for
deandja.🎩 'ed using https://github.com/Shopify/shopify-app-i18n-example
For Review: @kevinhughes27