Allow absolute URLs in ShopifyApp::LoginProtection.redirection_javascript #389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
ShopifyApp::LoginProtection.redirection_javascript
only allows you to pass in a relative URL (/login
). This is because we always set the location in#postMessage
to:Instead, we need to allow absolute URLs as well (
https//SHOP.myshopify.com/admin/charges
). We create a normalized link to do this:Tested in the following browsers:
Fixes #387