Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance log message and server action for new releases #3126

Conversation

Hungle2911
Copy link
Contributor

Motivation

Closes #2902

Currently, you can't view the server's recent updates within VS Code. To help users discover new features more easily, it would be beneficial to add a way to view the server's changelog direct from VS Code.

Implementation

  1. Enhance the log message that prints the version of the LSP to include a link to the release notes.
  2. Add an extra action to the language status item to open the changelog for the server version, which will require a new command to be added.
    That way, there are two points extra points of discovery in VS Code: the language status centre and the command palette

Manual Tests

Screen.Recording.2025-02-01.at.4.22.58.PM.mov

@Hungle2911 Hungle2911 requested a review from a team as a code owner February 1, 2025 21:35
Copy link

graphite-app bot commented Feb 1, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

lib/ruby_lsp/server.rb Outdated Show resolved Hide resolved
vscode/package.json Outdated Show resolved Hide resolved
vscode/package.json Outdated Show resolved Hide resolved
vscode/src/common.ts Outdated Show resolved Hide resolved
vscode/src/rubyLsp.ts Outdated Show resolved Hide resolved
vscode/src/status.ts Outdated Show resolved Hide resolved
@vinistock vinistock added enhancement New feature or request server This pull request should be included in the server gem's release notes labels Feb 3, 2025
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@vinistock vinistock merged commit b2a274f into Shopify:main Feb 3, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request server This pull request should be included in the server gem's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make server changelog available in VS Code
3 participants