fix duplicate ending tag on erb.html files(#3117) #3121
Merged
+0
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
andyw8
approved these changes
Jan 31, 2025
|
Confirmed that I also see this problem. |
jules-w2
added a commit
to immosquare/immosquare-vscode
that referenced
this pull request
Jan 31, 2025
|
@jules-w2 please sign the CLA. |
|
(since this is a trivial change, we can skip the CLA) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue manifests in two problematic behaviors: #3117
When modifying an existing ERB tag
<% Time.now %>by adding=or#, the editor incorrectly inserts an additional closing%>, resulting in malformed ERB syntax.The situation arises very often when you want to comment on a line that already exists in your views.<%#%> Time.now %>Similarly, when adding a comment symbol
=, the editor produces invalid nested ERB syntax:<%=%> Time.now %>This behavior is caused by the autoClosingPairs configuration in the ERB language settings, which automatically adds closing tags in situations where they should not be added.