Allow for under development feature flags #3119
Merged
+36
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
c2ba939 to
baabe7d
Compare
st0012
approved these changes
Jan 31, 2025
Merge activity
|
### Motivation In addition to being able to roll out feature flags gradually, it would be nice if we could have flags that are only on if explicitly enabled. That allows us to hide under development functionality that's not ready even for beta testers. This PR adds support for under development flags. ### Implementation Started considering -1 as the indication that a flag is under development. If the value is -1, that flag is not enabled based on the `all` setting and can only be turned on by explicitly opting in. ### Automated Tests Added a test.
baabe7d to
76294b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In addition to being able to roll out feature flags gradually, it would be nice if we could have flags that are only on if explicitly enabled. That allows us to hide under development functionality that's not ready even for beta testers.
This PR adds support for under development flags.
Implementation
Started considering -1 as the indication that a flag is under development. If the value is -1, that flag is not enabled based on the
allsetting and can only be turned on by explicitly opting in.Automated Tests
Added a test.