Index documents on modification #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
41cc250 to
826bd1a
Compare
st0012
reviewed
Dec 9, 2024
826bd1a to
2251c9d
Compare
st0012
approved these changes
Dec 10, 2024
|
Nice! I did notice an issue while testing: module Bar
def abc
end
end
class Foo
extend Bar
end
Foo.abcIf you remove the |
2251c9d to
e5b8c20
Compare
|
@andyw8 good catch. I updated the code to handle ancestor invalidation too. |
e5b8c20 to
41fc7d4
Compare
andyw8
approved these changes
Jan 6, 2025
|
Let's also update the docs to remove the part that begins "There is currently a technical limitation that code is only indexed when saved." |
41fc7d4 to
d03faf8
Compare
Merge activity
|
vinistock
added a commit
that referenced
this pull request
Jan 9, 2025
…es (#3030) ### Motivation One more bug fix to include in the next release 😅. In #2941, we started indexing unsaved files. However, we didn't fix the requests that were assuming the presence of a file path in entries with `T.must`. We need to handle the possibility of there not being a file path, so that we can account for entries in unsaved files. ### Implementation Fixed all of the occurrences I could find where we assumed the file path to be there. ### Automated Tests Added tests that reproduce each one of the bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1908
This PR starts indexing files upon modification in addition to on saves.
Implementation
The idea is to use the declaration listener together with all of the other listeners, so that we collect declaration changes within the same AST traversal. This allows us to catch any declaration modifications made before saving a file.
The biggest concern with this change is performance, but I think the next PR in this stack is doing a decent job at minimizing reindexes.
Automated Tests
Added tests.