Skip to content

Commit

Permalink
Use local Ruby LSP executable on node tests (#3016)
Browse files Browse the repository at this point in the history
### Motivation

Our node tests use the released version of the `ruby-lsp` gem, which is not a good choice. Yesterday, only after the release of v0.23, tests started failing and indicating a bug for Windows.

We need to run the node tests against the development version of the gem, so that we test the development version of the composed bundle logic.

### Implementation

Instead of installing `ruby-lsp` from rubygems, I started packaging the gem and installing that local version.
  • Loading branch information
vinistock authored Jan 7, 2025
1 parent 516cff3 commit 20dd705
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,19 @@ jobs:
chmod +x shadowenv
sudo mv shadowenv /usr/local/bin/shadowenv
- name: Install gems for node tests
shell: bash
run: |
gem install debug
gem build ruby-lsp.gemspec
build_path=$(find . -name "ruby-lsp-*.gem")
gem install "$build_path"
- name: Run tests
working-directory: ./vscode
env:
DISPLAY: ":99.0"
run: |
gem install ruby-lsp debug
yarn --frozen-lockfile
/usr/bin/Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
yarn run test
Expand Down

0 comments on commit 20dd705

Please sign in to comment.