Merge pull request #139 from Shopify/fix-sig-final-false-positive

lib/rubocop/cop/sorbet/signatures/signature_cop.rb

@@ -12,7 +12,11 @@ class SignatureCop < RuboCop::Cop::Cop
         @registry = Cop.registry # So we can properly subclass this cop
 
         def_node_matcher(:signature?, <<~PATTERN)
-          (block (send #allowed_recv :sig) (args) ...)
+          (block (send
+            {nil? #with_runtime? #without_runtime?}
+            :sig
+            (sym :final)?
+          ) (args) ...)
         PATTERN
 
         def_node_matcher(:with_runtime?, <<~PATTERN)
@@ -23,13 +27,6 @@ class SignatureCop < RuboCop::Cop::Cop
           (const (const (const nil? :T) :Sig) :WithoutRuntime)
         PATTERN
 
-        def allowed_recv(recv)
-          return true unless recv
-          return true if with_runtime?(recv)
-          return true if without_runtime?(recv)
-          false
-        end
-
         def on_block(node)
           on_signature(node) if signature?(node)
         end

spec/rubocop/cop/sorbet/signatures/enforce_signatures_spec.rb

@@ -13,6 +13,13 @@ def foo; end
       RUBY
     end
 
+    it "makes no offense if a top-level method has a signature" do
+      expect_no_offenses(<<~RUBY)
+        sig(:final) { void }
+        def foo; end
+      RUBY
+    end
+
     it "makes offense if a top-level method has no signature" do
       expect_offense(<<~RUBY)
         def foo; end