Allow liquid tag inside liquid tag #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How confident are you that this is what liquid-c does? |
|
Hi. As is, this PR would fail the following test case, but pass with liquid-c. def test_inline_liquid_tag_in_liquid_tag
assert_template_result('42', <<~LIQUID)
{%- liquid
liquid echo 42
-%}
LIQUID
end |
samdoiron
approved these changes
Jul 7, 2023
gmalette
approved these changes
Jul 10, 2023
markglenn
added a commit
to handlecommerce/liquex
that referenced
this pull request
Apr 26, 2024
Matches to liquid_c and liquid v5.5.0. Also, fix rounding with invalid precision
parameters to better match ruby's version of liquid.
Liquex currently converts {{ 0 | round 'invalid' }} to '0.0'. Ruby rounds this to '0'.
Ref: Shopify/liquid#1731
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why?
matches liquid-c behaviour
how?
just skip the liquid tag if it's inside a liquid tag, it essentially does not change any behaviour as far as I can see.EDIT: matching the actual liquid-c behaviour we now recursively parse the markup for liquid tags inside liquid tags. I have to decrease the line number by 1 because when tokenizing in liquid tag mode we always up line number by one, but really in this case we are staying in the same line.