don't cache string expressions to be more perfomant

Shopify · Nov 14, 2024 · c0e45c1 · c0e45c1
1 parent e0d54cc
commit c0e45c1
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/lib/liquid/expression.rb b/lib/liquid/expression.rb
@@ -81,16 +81,18 @@ def parse(markup)
 
         markup = markup.strip # markup can be a frozen string
 
+        if (markup.start_with?('"') && markup.end_with?('"')) ||
+          (markup.start_with?("'") && markup.end_with?("'"))
+          return markup[1..-2]
+        end
+
         return CACHE[markup] if CACHE.key?(markup)
 
         CACHE[markup] = inner_parse(markup)
       end
 
       def inner_parse(markup)
-        if (markup.start_with?('"') && markup.end_with?('"')) ||
-          (markup.start_with?("'") && markup.end_with?("'"))
-          return markup[1..-2]
-        elsif (markup.start_with?("(") && markup.end_with?(")")) && markup =~ RANGES_REGEX
+        if (markup.start_with?("(") && markup.end_with?(")")) && markup =~ RANGES_REGEX
           return RangeLookup.parse(Regexp.last_match(1), Regexp.last_match(2))
         end