Raise a syntax error for an invalid range literal for ruby liquid parity #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @charlespwd
Problem
Shopify/liquid#1607 fixed an exception during parsing, turning it into a proper Liquid::SyntaxError. However, that expression parsing had been ported to liquid-c, which had the same issue.
Solution
Use
rb_check_funcall
to handle the case where a literal range bound value doesn't respond toto_i
and raise the same syntax error.I'll open a corresponding liquid PR to fix the testing of this error.