Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup NPM provenance statements #2723

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Setup NPM provenance statements #2723

merged 2 commits into from
Jan 28, 2025

Conversation

wizardlyhel
Copy link
Contributor

WHY are these changes introduced?

Security requirement

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

Copy link
Contributor

shopify bot commented Jan 23, 2025

Oxygen deployed a preview of your hl-npm-provenance branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment January 27, 2025 9:16 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment January 27, 2025 9:16 PM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment January 27, 2025 9:16 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment January 27, 2025 9:16 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment January 27, 2025 9:17 PM

Learn more about Hydrogen's GitHub integration.

Copy link
Contributor

@rbshop rbshop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the various package.json files to include a repository field (from here)

Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

@wizardlyhel wizardlyhel merged commit 1b86701 into main Jan 28, 2025
12 checks passed
@wizardlyhel wizardlyhel deleted the hl-npm-provenance branch January 28, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants