Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CLI Check for Bundle Size, Rely on Server #1614

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

benwolfram
Copy link
Contributor

@benwolfram benwolfram commented Jan 5, 2024

WHY are these changes introduced?

When pushing a deployment that is too large, there is no way to track this in the admin or know what happened outside of the CLI feedback. We are looking to improve error messaging to better understand what has going wrong when a bundle size is greater than 10mb.

WHAT is this pull request doing?

I am removing the 10mb check on the CLI so that bundles that are too large create a deployment in the admin. The error messaging will now also available inside the admin on the deployment since there is a new record created.

We've added a server-side check prior to ensure there is still an error message being shown when running the CLI command.

HOW to test your changes?

Run npx shopify hydrogen deploy to create a deployment that is larger than 10mb and see error message back and that it shows up in the admin.

Also see it work normally when the bundle size is <10mb.

A warning should continue to show when >5mb and <10mb.

Happy to demo on a call.

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@benwolfram benwolfram requested a review from blittle January 5, 2024 17:51
@benwolfram benwolfram self-assigned this Jan 5, 2024
@blittle blittle merged commit eb0f4bc into main Jan 8, 2024
10 checks passed
@blittle blittle deleted the remove-ten-mb-check branch January 8, 2024 18:38
This was referenced Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants