Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default code organization in skeleton template #1612

Merged
merged 9 commits into from
Jan 10, 2024

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Jan 5, 2024

With #1608 , it will be better to reduce the size of server.ts so that we don't need to maintain things that don't change like the cart fragment or the AppSession. Also, I noticed some examples are starting to add utils/xyz while we already have utils.ts in the skeleton template, which would be 1 file and 1 folder with the same name. This PR moves all of that to app/lib, following loosely what we have in demo-store.

Thoughts about this?

We should probably update our i18n generator to setup also in app/lib/i18n.ts instead of server.ts.

@frandiox frandiox requested a review from a team January 5, 2024 11:02
Copy link
Contributor

@blittle blittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@frandiox frandiox merged commit 42ac413 into main Jan 10, 2024
10 checks passed
@frandiox frandiox deleted the fd-refactor-skeleton branch January 10, 2024 02:38
This was referenced Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants