🐛 fix csp for local env not recognizing localhost a valid #1591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The CSP bug was found when using ngrok as public domain for local development (needed for customer account API development)
Steps to re-produce:
npm run dev:app
WHAT is this pull request doing?
With a public domain,
localhost:*
SHOULD have been applied to enable the use of localhost:3100 for assets build. This rule was never hit while using localhost:3000 as domain sinceself
rule has precedent.This PR fix the rule by adding http protocol to the policy.
HOW to test your changes?
Follow the above steps to reproduce and see the errors for all asset related CSP errors goes away in browser.
Post-merge steps
Checklist