Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update server network debug tool #1511

Merged
merged 59 commits into from
Jan 11, 2024
Merged

Update server network debug tool #1511

merged 59 commits into from
Jan 11, 2024

Conversation

wizardlyhel
Copy link
Contributor

@wizardlyhel wizardlyhel commented Nov 15, 2023 •
edited
Loading

WHAT is this pull request doing?

Visually improve the server network timing tool.

  • Default to viewing one main request at a time
  • Show a table list of all associated requests
  • Show detail information of the request in side panel

Bug:

  • First request in the waterfall chart doesn't response to a click (flame-chart-js package bug)

Before merge

  • Clean up test code in demo store

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@wizardlyhel wizardlyhel marked this pull request as ready for review November 17, 2023 22:00
@github-actions github-actions bot had a problem deploying to preview December 14, 2023 22:07 Failure
blittle
blittle approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@blittle blittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@wizardlyhel wizardlyhel merged commit 335371c into main Jan 11, 2024
10 checks passed
@wizardlyhel wizardlyhel deleted the hl-network-debug branch January 11, 2024 19:40
This was referenced Jan 11, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frandiox frandiox frandiox left review comments

@blittle blittle blittle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wizardlyhel @blittle @frandiox