Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forwardRef to ExternalVideo and Video #1415

Merged
merged 6 commits into from
Jan 22, 2024
Merged

Add forwardRef to ExternalVideo and Video #1415

merged 6 commits into from
Jan 22, 2024

Conversation

andershagbard
Copy link
Contributor

@andershagbard andershagbard commented Oct 13, 2023

WHY are these changes introduced?

It's hard to add custom controls to video elements without having this.

WHAT is this pull request doing?

This PR adds forwardRef to Video and ExternalVideo components.

HOW to test your changes?

Use components with ref property, as the tests do.

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

No docs to generate.

@benjaminsehl benjaminsehl requested a review from a team December 1, 2023 14:50
@benjaminsehl
Copy link
Member

LGTM

@michenly
Copy link
Contributor

hi @andershagbard sorry about the delay. Would you mind resolving the conflicts and try again?

@andershagbard
Copy link
Contributor Author

Had to change the type for ExternalVideoProps as well, but looks pretty much 1:1 props.

Ref: https://dev.to/fnky/comment/1ebe1

@wizardlyhel wizardlyhel merged commit dc8f90d into Shopify:main Jan 22, 2024
8 of 9 checks passed
@andershagbard andershagbard deleted the add-refs branch January 23, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants