-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Codegen dependencies and make it stable #1108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8926b2e.
Note: example of problematic fragment that worked on lines(first: $numCartLines) {
nodes {
...CartLine
}
}
|
frandiox
commented
Oct 17, 2023
frandiox
changed the title
[WIP] Update codegen dependencies
Update Codegen dependencies and make it stable
Oct 17, 2023
Ready to review! 🙌 |
wizardlyhel
approved these changes
Oct 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to update codegen dependencies and make it stable.
It is blocked by some bug introduced upstream. The error thrown when generating the demo-store types is:Cannot read properties of null (reading 'union')
, from this line.It seems it can't infer selection nodes when using fragment spreads (around here).Fixed in dotansimha/graphql-code-generator#9709 . We are also patching this bug until this is merged and released.