Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eliminate use of client component re-exports #181

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

jplhomer
Copy link
Contributor

@jplhomer jplhomer commented Nov 9, 2021

Description

Since #67 was a thing, developers had to re-export client components from a local client component in their app in order to use a Hydrogen-provided client component, like Link.

No more, thanks to #7!

Additional context


Before submitting the PR, please make sure you do the following:

  • Add your change under the Unreleased heading in the package's CHANGELOG.md
  • Read the Contributing Guidelines
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
  • Update docs in this repository for your change, if needed

@jplhomer jplhomer requested review from travispamaral and a team November 9, 2021 19:51
@jplhomer jplhomer merged commit 01dd715 into main Nov 9, 2021
@jplhomer jplhomer deleted the jl-clean-up-re-exports branch November 9, 2021 21:52
rafaelstz pushed a commit to rafaelstz/hydrogen that referenced this pull request Mar 4, 2023
Log response status in development
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants