Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): support RN 0.77 #1484

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Conversation

huextrat
Copy link
Contributor

Description

Android is not building with RN 0.77 and FlashList

fixes: #1466

@tomekzaw patch seems to work well, so here is the PR

Reviewers’ hat-rack 🎩

  • [ ]

Screenshots or videos (if needed)

Checklist

@efstathiosntonas
Copy link
Contributor

@huextrat is this backwards compatible with older versions of react-native? Asking because @rnmapbox/maps needs this fix too.

@huextrat
Copy link
Contributor Author

@huextrat is this backwards compatible with older versions of react-native? Asking because @rnmapbox/maps needs this fix too.

@efstathiosntonas Tested on RN 0.76.6 and it works, BaseViewManager & LayoutShadowNode are available from a long time so this should work on previous versions also

@naqvitalha naqvitalha merged commit df3bdf6 into Shopify:main Jan 28, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[action needed] support RN 0.77
3 participants