Add new text and overlay settings to image with text #944
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -82,13 +82,92 @@ | |
| align-items: flex-start; | ||
| height: 100%; | ||
| justify-content: center; | ||
| align-self: center; | ||
| padding: 4rem calc(4rem / var(--font-body-scale)) 5rem; | ||
| } | ||
|
|
||
| .image-with-text__content--mobile-right > * { | ||
| align-self: flex-end; | ||
| text-align: right; | ||
| } | ||
|
|
||
| .image-with-text__content--mobile-center > * { | ||
| align-self: center; | ||
| text-align: center; | ||
| } | ||
|
|
||
| .image-with-text--overlap .image-with-text__content { | ||
| transform: translate(0 , -3rem); | ||
| width: 90%; | ||
| margin: 0 auto; | ||
| } | ||
|
|
||
| @media screen and (min-width: 750px) { | ||
| .image-with-text__grid--reverse .image-with-text__content { | ||
| margin-left: auto; | ||
| } | ||
|
|
||
| .image-with-text__content--bottom { | ||
| justify-content: flex-end; | ||
| align-self: flex-end; | ||
| } | ||
|
|
||
| .image-with-text__content--top { | ||
| justify-content: flex-start; | ||
| align-self: flex-start; | ||
| } | ||
|
|
||
| .image-with-text__content--desktop-right > * { | ||
| align-self: flex-end; | ||
| text-align: right; | ||
| } | ||
|
|
||
| .image-with-text__content--desktop-left > * { | ||
| align-self: flex-start; | ||
| text-align: left; | ||
| } | ||
|
|
||
| .image-with-text__content--desktop-center > * { | ||
| align-self: center; | ||
| text-align: center; | ||
martinamarien marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| .image-with-text--overlap .image-with-text__text-item { | ||
| display: flex; | ||
| padding: 3rem 0; | ||
|
There was a problem hiding this comment. We might want to remove this padding only at the top, only at the bottom or both depending on the Since we already have the margin on the section at the top and bottom. There was a problem hiding this comment. I still believe this is something to address to make sure we don't have unwanted space |
||
| } | ||
|
|
||
| .image-with-text--overlap .image-with-text__content { | ||
| height: auto; | ||
| width: calc(100% + 4rem); | ||
| min-width: calc(100% + 4rem); | ||
| transform: translate(-4rem, 0); | ||
| } | ||
|
|
||
| .image-with-text--overlap .image-with-text__grid--reverse .image-with-text__content { | ||
| transform: translate(4rem, 0); | ||
| } | ||
|
|
||
| .image-with-text--overlap .image-with-text__grid--reverse .image-with-text__text-item { | ||
| justify-content: flex-end; | ||
| } | ||
|
|
||
| .image-with-text--overlap .image-with-text__media-item--top { | ||
| align-self: flex-start; | ||
| } | ||
|
|
||
| .image-with-text--overlap .image-with-text__media-item--middle { | ||
| align-self: center; | ||
| } | ||
|
|
||
| .image-with-text--overlap .image-with-text__media-item--bottom { | ||
| align-self: flex-end; | ||
| } | ||
|
|
||
| .image-with-text__media-item--small, | ||
| .image-with-text__media-item--large + .image-with-text__text-item { | ||
| flex-grow: 0; | ||
| } | ||
| } | ||
|
|
||
| @media screen and (min-width: 990px) { | ||
|
|
@@ -105,11 +184,14 @@ | |
| margin-top: 2rem; | ||
| } | ||
|
|
||
| .image-with-text__content > :first-child:is(.image-with-text__heading), | ||
| .image-with-text__text--caption + .image-with-text__heading, | ||
| .image-with-text__text--caption:first-child { | ||
| margin-top: 0; | ||
| } | ||
|
|
||
| .image-with-text__content :last-child:is(.image-with-text__heading), | ||
| .image-with-text__text--caption { | ||
| margin-bottom: 0; | ||
| } | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This I think creates some extra space on mobile. Seems like using a negative margin-top makes it better: video