Fix accessible cart image link #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ludoboludo I might get a conflict from your PR, just for your information. |
svinkle
reviewed
Sep 9, 2021
kmeleta
previously approved these changes
Sep 10, 2021
286e4c9
8331dc3 to
286e4c9
Compare
ludoboludo
approved these changes
Sep 10, 2021
kmeleta
approved these changes
Sep 10, 2021
Merged
5 tasks
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
* Fix accesible cart image link: * add cursor pointer only on JS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes introduced?
Fixes #590
The goal of this PR is to fix the cart image link that cause accessibility issues
What approach did you take?
<a>link and replace byonclickevent per Scott's recommendationDemo links
Checklist