Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich Text section page width fix #564

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Rich Text section page width fix #564

merged 1 commit into from
Sep 3, 2021

Conversation

kmeleta
Copy link
Contributor

@kmeleta kmeleta commented Sep 3, 2021

Why are these changes introduced?

Fixes #519

What approach did you take?

The width/max-width were hard coded in the rich text stylesheet. I've adjusted to let the page-width handle these styles to ensure consistency with other sections.

Demo links

Checklist

@ludoboludo ludoboludo self-requested a review September 3, 2021 17:43
Copy link
Contributor

@ludoboludo ludoboludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested in the editor

@kmeleta kmeleta merged commit 2e74d84 into main Sep 3, 2021
@kmeleta kmeleta deleted the rich-text-width-fix branch September 3, 2021 18:29
@martinamarien martinamarien mentioned this pull request Sep 13, 2021
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rich Text does not respect layout setting 1600px
3 participants