-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix html closing tags issues in facets #561
Conversation
Hello @grumpyoldflo, thanks for looking into making Dawn better! I just had a look at your PR and we have changed some of the files structure and moved filtering in its own file, So your changes would still be needed but on that file now instead of the collection one. Do you want to rebase so the change are more up to date with the recent changes ? And I can then review the PR/approve it. Cheers! |
Hello @ludoboludo, Done. Cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks for doing this @grumpyoldflo 👌 I will try and get someone to review so we can have the two approvals required to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks for contributing to improve Dawn! :D
@grumpyoldflo 🙌 we're good to merge. |
Awesome, I am not allowed to do that, so next week then.👌 |
Why are these changes introduced?
To remove some unnecessary closing tags.
Checklist