Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix html closing tags issues in facets #561

Merged
merged 4 commits into from Oct 15, 2021
Merged

Fix html closing tags issues in facets #561

merged 4 commits into from Oct 15, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 3, 2021

Why are these changes introduced?

To remove some unnecessary closing tags.

Checklist

@ludoboludo
Copy link
Contributor

Hello @grumpyoldflo, thanks for looking into making Dawn better! I just had a look at your PR and we have changed some of the files structure and moved filtering in its own file, facets.liquid.

So your changes would still be needed but on that file now instead of the collection one. Do you want to rebase so the change are more up to date with the recent changes ? And I can then review the PR/approve it.

Cheers!

@ghost ghost changed the title Remove unnecessary html closing tags Fix html closing tags issues in facets Oct 7, 2021
@ghost
Copy link
Author

ghost commented Oct 7, 2021

Hello @ludoboludo,

Done. Cheers!

Copy link
Contributor

@ludoboludo ludoboludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for doing this @grumpyoldflo 👌 I will try and get someone to review so we can have the two approvals required to merge.

Copy link
Contributor

@LucasLacerdaUX LucasLacerdaUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thanks for contributing to improve Dawn! :D

@ludoboludo
Copy link
Contributor

@grumpyoldflo 🙌 we're good to merge.
I will let you press the green button if you're able to or else I can do it beginning of next week :)

@ghost
Copy link
Author

ghost commented Oct 15, 2021

Awesome, I am not allowed to do that, so next week then.👌

@ludoboludo ludoboludo merged commit 3359544 into Shopify:main Oct 15, 2021
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants