Blog zoom in duration #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably a question for @Oliviammarcello, but should this change apply to article cards in search results as well? Seems like a similar enough use case. I noticed that's also currently using 200ms. Otherwise lgtm. |
|
Good point. I think because the image/cards are smaller then the duration is a bit faster 🤔 |
Good point, but I think ludo is right. It should match the speed that the other search cards have, like the products cards. |
|
Other than updating the speed for the blog card on the search page it LGTM 👍 |
62f31ff to
c696ca4
Compare
Oliviammarcello
approved these changes
Sep 3, 2021
Merged
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes introduced?
Fixes #421
What approach did you take?
Change the variable it's using for the animation. Exactly what's mentioned in the issue, to change the duration from
200msto500ms.Other considerations
Demo links
Checklist
To test
Go into the footer menu and click on
Newsthen hover over the blog images.