Line-item content spacing on larger screens #553
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes introduced?
Fixes #531
What approach did you take?
At first I thought with dealing with the
padding-left
of the.cart-item__details
but instead I think it makes sense to have the image grow bigger. Looks like the space it takes can go up to150px
right now so I changed the image size to match. I also changed the source of the image to be twice the size of the image so that it can be a good quality image.Other considerations
On bigger screens the product image might make the line use more space but it might not be a bad thing 🤔
cc: @Oliviammarcello & @wiktoriaswiecicka :) (video explanation)
Demo links
Checklist
To test