Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line-item content spacing on larger screens #553

Merged
merged 3 commits into from
Sep 9, 2021

Conversation

ludoboludo
Copy link
Contributor

@ludoboludo ludoboludo commented Sep 2, 2021

Why are these changes introduced?

Fixes #531

What approach did you take?

At first I thought with dealing with the padding-left of the .cart-item__details but instead I think it makes sense to have the image grow bigger. Looks like the space it takes can go up to 150px right now so I changed the image size to match. I also changed the source of the image to be twice the size of the image so that it can be a good quality image.

Other considerations

On bigger screens the product image might make the line use more space but it might not be a bad thing 🤔
cc: @Oliviammarcello & @wiktoriaswiecicka :) (video explanation)

Demo links

Checklist

To test

  • You can add an item to the cart and then resize your browser to check how it looks on larger screens (past a 1000px wide)

@Oliviammarcello
Copy link
Contributor

On bigger screens the product image might make the line use more space but it might not be a bad thing 🤔
cc: @Oliviammarcello & @wiktoriaswiecicka :) (video explanation)

@ludoboludo Great update, I'm aligned to make the image fill the container width :)

@tauthomas01 tauthomas01 self-assigned this Sep 9, 2021
Copy link
Contributor

@tauthomas01 tauthomas01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, on Chrome/Safari/Firefox 👍

image

@kmeleta kmeleta self-requested a review September 9, 2021 18:37
Copy link
Contributor

@kmeleta kmeleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it 🚢

@ludoboludo ludoboludo merged commit 5179ab1 into main Sep 9, 2021
@ludoboludo ludoboludo deleted the line-item-content-spacing branch September 9, 2021 21:09
@martinamarien martinamarien mentioned this pull request Sep 13, 2021
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cart Template: Line Item Content Spacing
4 participants