Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations: merchant #528

Merged
merged 3 commits into from
Sep 1, 2021
Merged

Conversation

translation-platform[bot]
Copy link
Contributor

This PR modifies translations in the project. It will append multiple commits. Feel free to merge anytime.

Before you deploy

Questions?

@Shopify/themes-translations

ludoboludo
ludoboludo previously approved these changes Aug 31, 2021
ludoboludo
ludoboludo previously approved these changes Aug 31, 2021
Copy link
Contributor

@tyleralsbury tyleralsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON looks good. Are these all the translations we're looking for?

cc @martinamarien @KaichenWang

@martinamarien
Copy link
Contributor

I don't think so. I am only seeing the English "rating" translation in main. We have 21 languages for editor translations. That means we're still missing 5. I think we can merge though. They should be back in the next few days.

@ludoboludo ludoboludo merged commit e207d27 into main Sep 1, 2021
@ludoboludo ludoboludo deleted the translation-platform/async/merchant branch September 1, 2021 14:19
@martinamarien martinamarien mentioned this pull request Sep 13, 2021
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants