Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix js error switching variants when no media gallery exists #3428

Merged
merged 1 commit into from
Apr 18, 2024
Merged

🐛 Fix js error switching variants when no media gallery exists #3428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/global.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1156,7 +1156,7 @@ class VariantSelects extends HTMLElement {

document
.querySelector(`[id^="MediaGallery-${this.dataset.section}"]`)
.setActiveMedia(`${this.dataset.section}-${this.currentVariant.featured_media?.id}`);
?.setActiveMedia?.(`${this.dataset.section}-${this.currentVariant.featured_media?.id}`);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out, if a product has no media we still have a media gallery in the page, but setActiveMedia is undefined. Added conditionals to cover both the case of no media gallery and media gallery without the associated class functions.

// update media modal
const modalContent = document.querySelector(`#ProductModal-${this.dataset.section} .product-media-modal__content`);
Expand Down
Loading