Add top border on cart notification when "show separator line" setting is deactivated #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyleralsbury
previously approved these changes
Aug 3, 2021
Comment on lines
24
to
28
| .header-wrapper:not(.header-wrapper--border-bottom) | ||
| + cart-notification | ||
| .cart-notification { | ||
| border-top-width: 0.1rem; | ||
| } |
There was a problem hiding this comment.
Suggested change
| .header-wrapper:not(.header-wrapper--border-bottom) | |
| + cart-notification | |
| .cart-notification { | |
| border-top-width: 0.1rem; | |
| } | |
| .header-wrapper:not(.header-wrapper--border-bottom) + cart-notification .cart-notification { | |
| border-top-width: 0.1rem; | |
| } |
I find this easier to read, but I'm not strongly opinionated on the matter.
There was a problem hiding this comment.
Same. For a second I thought this was using some kind of nesting haha.
There was a problem hiding this comment.
I made the changes. It was Prettier VS code plugin who does the autoformatting so I disabled it.
4272f86
c041d81 to
4272f86
Compare
tyleralsbury
approved these changes
Aug 3, 2021
olafghanizadeh
pushed a commit
to hyttefeber/dawn
that referenced
this pull request
Aug 5, 2021
…g is deactivated (Shopify#306) * Add border on cart notification when header border setting is not active * adjust presentation of the selector
maplerock
added a commit
to fellowsmedia/nsra_shopify_2021
that referenced
this pull request
Aug 12, 2021
* main: (23 commits) Cart content update (Shopify#370) Footer spacing and alignment adjustments (Shopify#369) Product Template UI polish updates (Shopify#219) footer ui updates (Shopify#318) Fix cart improvements empty state (Shopify#319) [Announcement] Adjust block id for displaying dynamic names (Shopify#327) Update translations: buyer (Shopify#329) Revert editor setting changes (Shopify#328) Update translations (Shopify#294) Fix collection filtering UX (Shopify#268) Added page width setting and fixed image quality (Shopify#292) Add top border on cart notification when "show separator line" setting is deactivated (Shopify#306) movebadge code into base.css (Shopify#313) Collage UI bug fixes (Shopify#308) Customer account UI polish (Shopify#177) Added custom liquid block to product page (Shopify#269) Fix disclosure icon (Shopify#310) Fix facet price filter label spacing (Shopify#300) Fix duplicate search icon when header logo is set to "Top center" (Shopify#252) Add card outline setting (Shopify#239) ...
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
…g is deactivated (Shopify#306) * Add border on cart notification when header border setting is not active * adjust presentation of the selector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes introduced?
Fixes #278
The goal of this PR is to add a border top on the cart notification even when the header
Show separator linesetting is deactivated.Show separator line - Deactivated
Show separator line - Activated
What approach did you take?
.header-wrapper--border-bottomclass exist.Other considerations
{% render cart-notification %}snippet, but I thought it would be better to leverage native CSS, even though the selector looks more complicated.Demo links
Checklist