Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix-invalid-gtin-format-in-schemaorg-data-product-page #2804

Merged
merged 1 commit into from
Aug 9, 2023
Merged

fix-invalid-gtin-format-in-schemaorg-data-product-page #2804

merged 1 commit into from
Aug 9, 2023

Conversation

lougoncharenko
Copy link
Contributor

@lougoncharenko lougoncharenko commented Jul 10, 2023 •
edited
Loading

PR Summary:

Fixed invalid gtin format in the data product page

Why are these changes introduced?

Fixes #2548 .

What approach did you take?

Changed {{ variant.barcode }} to {{ variant.barcode | json }}

Visual impact on existing themes

N/A

Testing steps/scenarios

Testing gtin12

  • Add the barcode 012345678912 to a variant.
  • View the product page.
  • Check validity of the schema.org structured data on that page.

Testing gtin13

  • Add the barcode 0123456789123 to a variant.
  • View the product page.
  • Check validity of the schema.org structured data on that page.

Testing gtin14

  • Add the barcode 01234567891234 to a variant.
  • View the product page.
  • Check validity of the schema.org structured data on that page.

Demo links

Checklist

@lougoncharenko lougoncharenko added the Category: Bug Something isn't working label Jul 10, 2023
@lougoncharenko lougoncharenko self-assigned this Jul 10, 2023
@lougoncharenko lougoncharenko linked an issue Jul 10, 2023 that may be closed by this pull request
Invalid gtin format in Schema.org data (product page) #2548
Closed
kmeleta
kmeleta approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@kmeleta kmeleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lougoncharenko lougoncharenko merged commit 73793c0 into main Aug 9, 2023
@lougoncharenko lougoncharenko deleted the fix-invalid-gtin-format-in-schemaorg-data-product-page branch August 9, 2023 15:25
@naxorn naxorn mentioned this pull request Aug 11, 2023
Closed
TimmersThomas added a commit to TimmersThomas/shopify-template-houseofchocolate that referenced this pull request Aug 13, 2023
@TimmersThomas
Merge remote-tracking branch 'upstream/main'
f6b8f50 
* upstream/main: (205 commits)
  Fix for small screens with large fonts don't fit all content (Shopify#2946)
  Adjust quantity rules margin (Shopify#2948)
  Update Social media settings defaults to remove Shopify links (Shopify#2830)
  added json to barcode to pass gtin as a json string (Shopify#2804)
  Fixed extra margin spacing in collage section when header is empty (Shopify#2770)
  Track state of mouseenter event (Shopify#2934)
  Fix misalignment of total items in quick order list (Shopify#2923)
  Hide vol pricing and qty rules when variant is unavailable (Shopify#2889)
  Fix font family for quick order list (Shopify#2888)
  v11.0.0 version bump and release notes (Shopify#2916)
  Revert "v11.0.0 version bump and release notes (Shopify#2906)" (Shopify#2915)
  Update quantity-popover.css
  v11.0.0 version bump and release notes (Shopify#2906)
  Fix social list styles loading (Shopify#2900)
  Fix an error (Shopify#2903)
  Fix hardcoded info color (Shopify#2893)
  Fix error misalignment for Quick order list (Shopify#2887)
  Replace generic section name with section ID. (Shopify#2884)
  Fix cart drawer for variant list and tablet spacing (Shopify#2880)
  Add missing shadow styles to inputs in Quick Order List (Shopify#2879)
  ...
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
@lougoncharenko
added json to barcode to pass gtin as a json string (Shopify#2804)
addc635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmeleta kmeleta kmeleta approved these changes

@stephanie-shopify stephanie-shopify stephanie-shopify approved these changes

@KaichenWang KaichenWang Awaiting requested review from KaichenWang

Assignees

@lougoncharenko lougoncharenko

Labels
Category: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid gtin format in Schema.org data (product page)
3 participants
@lougoncharenko @kmeleta @stephanie-shopify