Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Announcement bar] Change auto rotate announcements copy and min value #2787

Merged
merged 5 commits into from
Jul 8, 2023
Merged

[Announcement bar] Change auto rotate announcements copy and min value #2787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
10aebbd
Change auto rotate announcements copy and min value
ludoboludo Jul 6, 2023
4bdc563
adjust copy based on feedback
ludoboludo Jul 6, 2023
655f533
Update 4 translation files
translation-platform[bot] Jul 7, 2023
3211f54
Update 14 translation files
translation-platform[bot] Jul 7, 2023
1d1b436
Update 2 translation files
translation-platform[bot] Jul 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions locales/cs.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,10 @@
},
"settings": {
"auto_rotate": {
"label": "Automaticky střídat oznámení"
"label": "Automaticky střídat na ploše"
},
"change_slides_speed": {
"label": "Změnit snímek co"
"label": "Změnit co"
},
"header__1": {
"content": "Ikony sociálních sítí",
Expand Down
4 changes: 2 additions & 2 deletions locales/da.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,10 @@
},
"settings": {
"auto_rotate": {
"label": "Roter meddelelser automatisk"
"label": "Automatisk rotation på computer"
},
"change_slides_speed": {
"label": "Skift slide hver"
"label": "Skift hver"
},
"header__1": {
"content": "Ikoner for sociale medier",
Expand Down
4 changes: 2 additions & 2 deletions locales/de.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,10 @@
},
"settings": {
"auto_rotate": {
"label": "Autorotieren der Ankündigungen"
"label": "Autorotieren auf Desktop-Gerät"
},
"change_slides_speed": {
"label": "Anzeige der nächsten Folie alle"
"label": "Ändern alle"
},
"header__1": {
"content": "Social-Media-Symbole",
Expand Down
4 changes: 2 additions & 2 deletions locales/en.default.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,10 +448,10 @@
"name": "Announcement bar",
"settings": {
"auto_rotate": {
"label": "Auto-rotate announcements"
"label": "Auto-rotate on desktop"
},
"change_slides_speed": {
"label": "Change slides every"
"label": "Change every"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization quality issue found

The following issues may affect the quality of localized translations if they are not addressed:

  • The value Change every for key sections.announcement-bar.settings.change_slides_speed.label is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the screenshot to share more context around that change 👍

},
"header__1": {
"content": "Social media icons",
Expand Down
4 changes: 2 additions & 2 deletions locales/es.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,10 @@
},
"settings": {
"auto_rotate": {
"label": "Rotar anuncios automáticamente"
"label": "Girar automáticamente en el escritorio"
},
"change_slides_speed": {
"label": "Cambiar de diapositiva cada"
"label": "Cambiar cada"
},
"header__1": {
"content": "Íconos de redes sociales",
Expand Down
4 changes: 2 additions & 2 deletions locales/fi.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,10 @@
},
"settings": {
"auto_rotate": {
"label": "Kierrä ilmoituksia automaattisesti"
"label": "Käännä automaattisesti työpöydällä"
},
"change_slides_speed": {
"label": "Vaihda diat joka"
"label": "Vaihda joka"
},
"header__1": {
"content": "Some-kuvakkeet",
Expand Down
4 changes: 2 additions & 2 deletions locales/fr.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,10 @@
},
"settings": {
"auto_rotate": {
"label": "Rotation automatique des annonces"
"label": "Rotation automatique sur le bureau"
},
"change_slides_speed": {
"label": "Changer de diapositive toutes les"
"label": "Changer toutes les"
},
"header__1": {
"content": "Icônes de réseaux sociaux",
Expand Down
4 changes: 2 additions & 2 deletions locales/it.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,10 @@
},
"settings": {
"auto_rotate": {
"label": "Ruota annunci automaticamente"
"label": "Ruota automaticamente su desktop"
},
"change_slides_speed": {
"label": "Cambia slide ogni"
"label": "Cambio"
},
"header__1": {
"content": "Icone dei social media",
Expand Down
4 changes: 2 additions & 2 deletions locales/ja.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,10 @@
},
"settings": {
"auto_rotate": {
"label": "自動切り替えのお知らせ"
"label": "デスクトップ上の自動切り替え"
},
"change_slides_speed": {
"label": "スライドを変更する間隔"
"label": "変更する間隔"
},
"header__1": {
"content": "SNSのアイコン",
Expand Down
4 changes: 2 additions & 2 deletions locales/ko.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,10 @@
},
"settings": {
"auto_rotate": {
"label": "공지 사항 자동 회전"
"label": "데스크톱에서 자동 회전"
},
"change_slides_speed": {
"label": "슬라이드 변경 간격"
"label": "변경 간격"
},
"header__1": {
"content": "소셜 미디어 아이콘",
Expand Down
4 changes: 2 additions & 2 deletions locales/nb.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,10 @@
},
"settings": {
"auto_rotate": {
"label": "Roter kunngjøringer automatisk"
"label": "Roter automatisk på stasjonære datamaskiner"
},
"change_slides_speed": {
"label": "Endre lysbilde hvert"
"label": "Endre hver"
},
"header__1": {
"content": "Ikoner for sosiale medier",
Expand Down
4 changes: 2 additions & 2 deletions locales/nl.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,10 @@
},
"settings": {
"auto_rotate": {
"label": "Aankondigingen automatisch draaien"
"label": "Automatisch draaien op desktop"
},
"change_slides_speed": {
"label": "Wissel dia's elke"
"label": "Wijzig elke"
},
"header__1": {
"content": "Pictogrammen voor social media",
Expand Down
4 changes: 2 additions & 2 deletions locales/pl.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,10 @@
},
"settings": {
"auto_rotate": {
"label": "Automatyczna zmiana ogłoszeń"
"label": "Automatyczna zmiana na pulpicie"
},
"change_slides_speed": {
"label": "Zmieniaj slajdy co"
"label": "Zmieniaj co"
},
"header__1": {
"content": "Ikony mediów społecznościowych",
Expand Down
4 changes: 2 additions & 2 deletions locales/pt-BR.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,10 @@
},
"settings": {
"auto_rotate": {
"label": "Girar automaticamente os comunicados"
"label": "Girar automaticamente no desktop"
},
"change_slides_speed": {
"label": "Mudar os slides a cada"
"label": "Mudar a cada"
},
"header__1": {
"content": "Ícones de redes sociais",
Expand Down
4 changes: 2 additions & 2 deletions locales/pt-PT.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,10 @@
},
"settings": {
"auto_rotate": {
"label": "Rotação automática de comunicados"
"label": "Rotação automática no computador"
},
"change_slides_speed": {
"label": "Mudar diapositivos a cada"
"label": "Mudar a cada"
},
"header__1": {
"content": "Ícones de redes sociais",
Expand Down
4 changes: 2 additions & 2 deletions locales/sv.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,10 @@
},
"settings": {
"auto_rotate": {
"label": "Rotera meddelanden automatiskt"
"label": "Rotera automatiskt på skrivbordet"
},
"change_slides_speed": {
"label": "Byt bilder var"
"label": "Byt varje"
},
"header__1": {
"content": "Sociala medier-ikoner",
Expand Down
4 changes: 2 additions & 2 deletions locales/th.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,10 @@
},
"settings": {
"auto_rotate": {
"label": "เปลี่ยนประกาศอัตโนมัติ"
"label": "เปลี่ยนอัตโนมัติบนเดสก์ท็อป"
},
"change_slides_speed": {
"label": "เปลี่ยนสไลด์ทุก"
"label": "เปลี่ยนทุก"
},
"header__1": {
"content": "ไอคอนโซเชียลมีเดีย",
Expand Down
4 changes: 2 additions & 2 deletions locales/tr.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,10 @@
},
"settings": {
"auto_rotate": {
"label": "Duyuruları otomatik olarak döndür"
"label": "Masaüstünde otomatik olarak döndür"
},
"change_slides_speed": {
"label": "Slaytları şu zaman aralığında değiştir:"
"label": "Şu zaman aralığında değiştir:"
},
"header__1": {
"content": "Sosyal medya simgeleri",
Expand Down
4 changes: 2 additions & 2 deletions locales/vi.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,10 @@
},
"settings": {
"auto_rotate": {
"label": "Tự động xoay vòng thông báo"
"label": "Tự động xoay trên màn hình nền"
},
"change_slides_speed": {
"label": "Đổi trang chiếu sau mỗi"
"label": "Thay đổi sau mỗi"
},
"header__1": {
"content": "Biểu tượng mạng xã hội",
Expand Down
4 changes: 2 additions & 2 deletions locales/zh-CN.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,10 @@
},
"settings": {
"auto_rotate": {
"label": "自动循环展示公告"
"label": "在桌面上自动轮换"
},
"change_slides_speed": {
"label": "幻灯片更换时间间隔"
"label": "更换时间间隔"
},
"header__1": {
"content": "社交媒体图标",
Expand Down
4 changes: 2 additions & 2 deletions locales/zh-TW.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,10 @@
},
"settings": {
"auto_rotate": {
"label": "自動輪播公告"
"label": "在桌上型裝置自動旋轉"
},
"change_slides_speed": {
"label": "每過以下時間即變更投影片"
"label": "變更頻率"
},
"header__1": {
"content": "社群媒體圖示",
Expand Down
2 changes: 1 addition & 1 deletion sections/announcement-bar.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@
{
"type": "range",
"id": "change_slides_speed",
"min": 5,
"min": 3,
"max": 10,
"step": 1,
"unit": "s",
Expand Down