-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix collection filtering UX #268
Merged
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
a53694c
Add setting to enable filtering drawer on larger devices. Adjust butt…
KaichenWang 530342f
Update styling. Tighten spacing
KaichenWang dbe6059
Update from Shopify for theme dawn/fix-collection-filtering-ux
shopify[bot] adfd047
Update from Shopify for theme dawn/fix-collection-filtering-ux
shopify[bot] 448e7c3
Update from Shopify for theme dawn/fix-collection-filtering-ux
shopify[bot] ebd55fe
Update from Shopify for theme dawn/fix-collection-filtering-ux
shopify[bot] 5a9907b
Merge branch 'main' of https://github.com/Shopify/dawn into fix-colle…
KaichenWang 162eaf3
Update styles and spacing for filters
KaichenWang 3dcf91c
Adjust font sizes for filters
KaichenWang 22f6306
Adjust alignment and spacing
KaichenWang 93eb5c9
Update from Shopify for theme dawn/fix-collection-filtering-ux
shopify[bot] 7915432
Update from Shopify for theme dawn/fix-collection-filtering-ux
shopify[bot] be307cd
Update link style for clear
KaichenWang 76d7b51
Update from Shopify for theme dawn/fix-collection-filtering-ux
shopify[bot] 2c9be9c
Merge branch 'fix-collection-filtering-ux' of https://github.com/Shop…
KaichenWang d788172
Merge branch 'main' of https://github.com/Shopify/dawn into fix-colle…
KaichenWang dc88f7b
Address design feedback
KaichenWang 160e2b0
Merge branch 'main' of https://github.com/Shopify/dawn into fix-colle…
KaichenWang a1dd53a
Update locales
KaichenWang 4091959
Merge branch 'main' of https://github.com/Shopify/dawn into fix-colle…
KaichenWang 561c858
Merge branch 'main' of https://github.com/Shopify/dawn into fix-colle…
KaichenWang 8062e64
Update locales/cs.schema.json
translation-platform 50c7a29
Update locales/da.schema.json
translation-platform 7b0515a
Update locales/de.schema.json
translation-platform 7c3fa8b
Update locales/es.schema.json
translation-platform 62d1774
Update locales/fi.schema.json
translation-platform e415666
Update locales/fr.schema.json
translation-platform 1a90c93
Update locales/it.schema.json
translation-platform 9b6a215
Update locales/ja.schema.json
translation-platform f7ce79b
Update locales/ko.schema.json
translation-platform 1c01ba0
Update locales/nb.schema.json
translation-platform d5b31e4
Update locales/nl.schema.json
translation-platform dac1ee9
Update locales/pl.schema.json
translation-platform 63bc3aa
Update locales/pt-BR.schema.json
translation-platform 3f796ea
Update locales/pt-PT.schema.json
translation-platform c08219e
Update locales/sv.schema.json
translation-platform 6f46969
Update locales/th.schema.json
translation-platform 28a3682
Update locales/tr.schema.json
translation-platform 8779bfb
Update locales/vi.schema.json
translation-platform c422df0
Update locales/zh-CN.schema.json
translation-platform 212e99a
Update locales/zh-TW.schema.json
translation-platform efd9d52
Remove bubble for price filtering
KaichenWang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nitpick: does it work if we use optional chaining?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually an interesting case - you can't use optional chaining for the left side of an assignment.
You can see the discussion on the proposal here:
tc39/proposal-optional-chaining#18