Bump lighthouse-ci-action to 1.1.1 and checkout to v3 #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stufreen
commented
Apr 4, 2023
| with: | ||
| store: ${{ secrets.SHOP_STORE_OS2 }} | ||
| password: ${{ secrets.SHOP_PASSWORD_OS2 }} | ||
| access_token: ${{ secrets.SHOP_ACCESS_TOKEN }} | ||
| product_handle: puppy |
There was a problem hiding this comment.
By default lighthouse-ci-action will use the first product. puppy only works for the os2-demo shop, but I'm planning to switch to theme-design-ci.
stufreen
commented
Apr 4, 2023
.github/workflows/ci.yml
Outdated
| collection_handle: all | ||
| lhci_github_app_token: ${{ secrets.LHCI_GITHUB_TOKEN }} | ||
| access_token: ${{ secrets.SHOP_PULL_THEME }} |
There was a problem hiding this comment.
The ID or name of a theme from which the settings and JSON templates should be used. If not provided Lighthouse will be run against the theme's default settings.
98bf014 to
17cff5a
Compare
eugenekasimov
approved these changes
Apr 4, 2023
andrewetchen
reviewed
Apr 4, 2023
| theme-check: | ||
| name: Theme Check | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
Just noting that this takes care of part of this issue 👍🏼
andrewetchen
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
I'll 🎩 but definitely wait for others to review this.
Also, thanks for adding the pull_theme option to lighthouse-ci-action 😄
metamoni
approved these changes
Apr 5, 2023
9 tasks
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Update Github actions to use the latest versions.
Why are these changes introduced?
Fixes https://github.com/Shopify/dawn-private/issues/142
What approach did you take?
pull_themeoption to lighthouse-ci-action. This lets us pull theme settings from a store to match real-world use cases instead of always testing against default settings.Other considerations
Both changes should have no impact on CI except possibly speeding up/slowing down CI. I will update the environment variables to change the Lighthouse store.
Decision log
Visual impact on existing themes
n/a
Testing steps/scenarios
No theme testing required. Check github actions in CI to ensure its running as usual.
Demo links
N/A - No theme changes
Checklist