-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use collection.featured_image instead of image #245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and looks good.
edf739e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Love when something already exists for an elegant solution.
@@ -540,4 +540,4 @@ | |||
} | |||
] | |||
} | |||
{% endschema %} | |||
{% endschema %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{% endschema %} | |
{% endschema %} | |
* use collection.featured_image instead of image * Update from Shopify for theme dawn/fix-collection-card-image * Update from Shopify for theme dawn/fix-collection-card-image * Update from Shopify for theme dawn/fix-collection-card-image * Update from Shopify for theme dawn/fix-collection-card-image * Update from Shopify for theme dawn/fix-collection-card-image * Update from Shopify for theme dawn/fix-collection-card-image * Update from Shopify for theme dawn/fix-collection-card-image * Update from Shopify for theme dawn/fix-collection-card-image * Update from Shopify for theme dawn/fix-collection-card-image * Update from Shopify for theme dawn/fix-collection-card-image * Update from Shopify for theme dawn/fix-collection-card-image * Update from Shopify for theme dawn/fix-collection-card-image * Update from Shopify for theme dawn/fix-collection-card-image * Update from Shopify for theme dawn/fix-collection-card-image * revert setting changes made by online store git * fix end of line Co-authored-by: shopify-online-store[bot] <79544226+shopify-online-store[bot]@users.noreply.github.com>
Why are these changes introduced?
Currently, the collection card only displays the collection image, if one exists.
In other themes, we use the collection's first product image as a fallback, if one exists.
Fixes #172
What approach did you take?
We recently introduced the new
featured_image
property on thecollection
object.By using this property, it means:
This PR converts
collection.image
tocollection.featured_image
in three places:Other considerations
N/A
Demo links
See test store
Testing and reviewing
Checklist