Code

Gift cards/add recipient#2412

Code

Merged

ludoboludo merged 70 commits intomainShopify/dawn:mainfrom gift-cards/add-recipientShopify/dawn:gift-cards/add-recipientCopy head branch name to clipboardMar 21, 2023

+1,334-346

Commits

Commits on Mar 17, 2023

• Gift cards/add recipient add template (#102)

  Show description for c49fbe9
  

  fredma

  authored and

  antiBaconMachine

  committed
  c49fbe9

  Copy full SHA for c49fbe9

• Align gift card recipient checkbox to 1st line of text (#129)

  

  fredma

  authored and

  antiBaconMachine

  committed
  e61dbff

  Copy full SHA for e61dbff

• Clear Gift Card Recipient Form upon untick and cart adding(#132)

  

  fredma

  authored and

  antiBaconMachine

  committed
  bc5dead

  Copy full SHA for bc5dead

• Rename gift card template recipient line item properties

  

  mzarud

  authored and

  antiBaconMachine

  committed
  e3f0cb5

  Copy full SHA for e3f0cb5

• Improve properties display for gift card recipient (#137)

  

  fredma

  authored and

  antiBaconMachine

  committed
  89d3e65

  Copy full SHA for 89d3e65

• Display gift card balance on the Gift Card View page

  

  DanamiteGS

  authored and

  antiBaconMachine

  committed
  41467d2

  Copy full SHA for 41467d2

• feat(#51542) Set the hidden control field in one of two ways

  Show description for fa1d844
  antiBaconMachine

  committed
  fa1d844

  Copy full SHA for fa1d844

• Remove nested form elements from buy button snippets

  Show description for a7884a1
  antiBaconMachine

  committed
  a7884a1

  Copy full SHA for a7884a1

• fix(#51542): wrap dummy form in product form class

  Show description for 64488ef
  antiBaconMachine

  committed
  64488ef

  Copy full SHA for 64488ef

• feat(#51543): Correct checkbox bahvior in all cases

  Show description for 247a4e9
  antiBaconMachine

  committed
  247a4e9

  Copy full SHA for 247a4e9

• feat(#51543): use the .no-js and .js classes to avoid content flashes at page load

  antiBaconMachine

  committed
  e9380e0

  Copy full SHA for e9380e0

• feat(#51731): Change the label on the recipient email field depending on wether the client has JS enabled

  antiBaconMachine

  committed
  b9f5486

  Copy full SHA for b9f5486

• feat(#51542): Error formatting for no js recipient form

  Show description for 1e9763f
  antiBaconMachine

  committed
  1e9763f

  Copy full SHA for 1e9763f

• fix: lower case field names

  Show description for 49d19d5
  antiBaconMachine

  committed
  49d19d5

  Copy full SHA for 49d19d5

• Restore buy buttons to their own block

  Show description for 793406a
  antiBaconMachine

  committed
  793406a

  Copy full SHA for 793406a

• This attempts to standardise error handling between liquid and javascript

  Show description for 1bb0d96
  

  antiBaconMachine

  and

  fredma

  committed
  1bb0d96

  Copy full SHA for 1bb0d96

• clear error message when the checkbox is unchecked

  antiBaconMachine

  committed
  617fc7f

  Copy full SHA for 617fc7f

• add error handling for name and message.

  Show description for f92b3d4
  antiBaconMachine

  committed
  f92b3d4

  Copy full SHA for f92b3d4

• close textarea immediately to avoid prefilling with spaces

  antiBaconMachine

  committed
  16f7fb2

  Copy full SHA for 16f7fb2

• Use the error icon snippet instead of copypasta

  antiBaconMachine

  committed
  70040ec

  Copy full SHA for 70040ec

• remove some form sizing

  Show description for 84d8e85
  antiBaconMachine

  committed
  84d8e85

  Copy full SHA for 84d8e85

• remove input field styling from form element

  Show description for 46e9e2b
  antiBaconMachine

  committed
  46e9e2b

  Copy full SHA for 46e9e2b

• copy max-width from product form to recipient form

  antiBaconMachine

  committed
  517d99c

  Copy full SHA for 517d99c

• Add show errors option to buy buttons snippet on main product template

  antiBaconMachine

  committed
  57cb5a7

  Copy full SHA for 57cb5a7

• update recipient block copy

  antiBaconMachine

  committed
  053cf8e

  Copy full SHA for 053cf8e

• Group repeated css rules

  Show description for d624c4b
  

  antiBaconMachine

  and

  ludoboludo

  committed
  d624c4b

  Copy full SHA for d624c4b

• Access form state for message in the correct location

  

  fredma

  authored and

  antiBaconMachine

  committed
  701e107

  Copy full SHA for 701e107

• Split up errors into their respective fields

  Show description for 73a7cd3
  antiBaconMachine

  committed
  73a7cd3

  Copy full SHA for 73a7cd3

• swap html hidden for css display: none

  antiBaconMachine

  committed
  ec25e91

  Copy full SHA for ec25e91

• fix inline svg error icons

  antiBaconMachine

  committed
  fbcb62f

  Copy full SHA for fbcb62f

• only apply hidden style to form fields, not error header

  antiBaconMachine

  committed
  17defb7

  Copy full SHA for 17defb7

• enumerate errors

  antiBaconMachine

  committed
  ab74e9b

  Copy full SHA for ab74e9b

• Don't clear error header text as it is static and liquid generated

  antiBaconMachine

  committed
  c29e433

  Copy full SHA for c29e433

• link to field not error message

  antiBaconMachine

  committed
  a8cea7f

  Copy full SHA for a8cea7f

• clear error messages before rendering new ones

  antiBaconMachine

  committed
  aa7b4e5

  Copy full SHA for aa7b4e5

• copy liquid from email to name and message errors

  antiBaconMachine

  committed
  e94ecf0

  Copy full SHA for e94ecf0

• Read localised field labels from DOM

  Show description for cd8f958
  antiBaconMachine

  committed
  cd8f958

  Copy full SHA for cd8f958

• Save default error message header and restore it when needed

  Show description for b61ae4a
  antiBaconMachine

  committed
  b61ae4a

  Copy full SHA for b61ae4a

• add period after error message

  Show description for 9543809
  antiBaconMachine

  committed
  9543809

  Copy full SHA for 9543809

• rename recipient block

  antiBaconMachine

  committed
  722bfee

  Copy full SHA for 722bfee

• rename recipient form internals

  antiBaconMachine

  committed
  4a2a92f

  Copy full SHA for 4a2a92f

• Don't abbreviate 'Element'

  antiBaconMachine

  committed
  e698fc0

  Copy full SHA for e698fc0

• Use single line if expressions

  Show description for c251a19
  antiBaconMachine

  committed
  c251a19

  Copy full SHA for c251a19

• remove gitt card template and graft recipient form onto buy buttons block

  antiBaconMachine

  committed
  091373d

  Copy full SHA for 091373d

• PR feedback

  Show description for b470d20
  antiBaconMachine

  committed
  b470d20

  Copy full SHA for b470d20

• refactor the recipient form into its own snippet

  antiBaconMachine

  committed
  f9f50d6

  Copy full SHA for f9f50d6

• PR feedback, mainly whitespace and semantic tweaks

  antiBaconMachine

  committed
  b656d7a

  Copy full SHA for b656d7a

• Add aria-labelledby attributes to form

  Show description for fe869bb
  antiBaconMachine

  committed
  fe869bb

  Copy full SHA for fe869bb

• Various whitespace and stylistic fixes

  Show description for 6aa7f56
  

  antiBaconMachine

  and

  ludoboludo

  committed
  6aa7f56

  Copy full SHA for 6aa7f56

• rename class to be more bem-like

  antiBaconMachine

  committed
  f753c47

  Copy full SHA for f753c47

• remove gift card recipient form block

  Show description for 2a81400
  antiBaconMachine

  committed
  2a81400

  Copy full SHA for 2a81400

• Remove leading labels from fields

  Show description for d30acab
  antiBaconMachine

  committed
  d30acab

  Copy full SHA for d30acab

• UX feedback fixes

  Show description for ff95e95
  antiBaconMachine

  committed
  ff95e95

  Copy full SHA for ff95e95

• use plaeholder instead of label as error key

  Show description for e562f4e
  antiBaconMachine

  committed
  e562f4e

  Copy full SHA for e562f4e

• Dynamically calculate available space for label

  Show description for fd30c0d
  

  antiBaconMachine

  and

  ludoboludo

  committed
  fd30c0d

  Copy full SHA for fd30c0d

• Copy updates for gift card toggle

  antiBaconMachine

  committed
  405e665

  Copy full SHA for 405e665

• default feature to off

  antiBaconMachine

  committed
  92380a6

  Copy full SHA for 92380a6

• Update 20 translation files

  

  translation-platform[bot]

  authored and

  antiBaconMachine

  committed
  69b07ee

  Copy full SHA for 69b07ee

• Update 5 translation files

  

  translation-platform[bot]

  authored and

  antiBaconMachine

  committed
  7cd7e6c

  Copy full SHA for 7cd7e6c

• Update 16 translation files

  

  translation-platform[bot]

  authored and

  antiBaconMachine

  committed
  5fd63f7

  Copy full SHA for 5fd63f7

• Update 5 translation files

  

  translation-platform[bot]

  authored and

  antiBaconMachine

  committed
  f1a3246

  Copy full SHA for f1a3246

• Update 4 translation files

  

  translation-platform[bot]

  authored and

  antiBaconMachine

  committed
  c9b9283

  Copy full SHA for c9b9283

Commits on Mar 20, 2023

• Increase stroke width of checkbox

  antiBaconMachine

  committed
  e192755

  Copy full SHA for e192755

• remove unused variable

  antiBaconMachine

  committed
  149b323

  Copy full SHA for 149b323

• Merge branch 'main' into gift-cards/add-recipient

  antiBaconMachine

  authored
  0204dfe

  Copy full SHA for 0204dfe

Commits on Mar 21, 2023

• Update snippets/gift-card-recipient-form.liquid

  Show description for 8e29538
  

  antiBaconMachine

  and

  ludoboludo

  authored
  8e29538

  Copy full SHA for 8e29538

• Update snippets/gift-card-recipient-form.liquid

  Show description for f578763
  

  antiBaconMachine

  and

  ludoboludo

  authored
  f578763

  Copy full SHA for f578763

• Remove leftover stuff for gift card block which no longer exists

  antiBaconMachine

  committed
  e720fba

  Copy full SHA for e720fba

• remove text alignement for order page, tweak check icon to match facet filters

  ludoboludo

  committed
  d305bac

  Copy full SHA for d305bac

• fix translation file issue

  ludoboludo

  committed
  4cecb78

  Copy full SHA for 4cecb78