Default Follow on Shop to Enabled #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludoboludo
approved these changes
Feb 24, 2023
I struggled with this one as when its enabled it would show, which is what it does now. But I guess the default is not to show so your reasoning makes sense. |
kmeleta
approved these changes
Mar 1, 2023
LucasLacerdaUX
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
In the footer, the
enable Follow on Shopsetting should default to true.Why are these changes introduced?
Fixes #2328
Visual impact on existing themes
Assuming that the merchant meets all the criteria for Follow on Shop, the Follow on Shop button will appear in the footer.
Testing steps/scenarios
footersectionDemo links
Checklist