Remove "hover" option for image zoom #2283
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1424,18 +1424,13 @@ | |
| "value": "lightbox", | ||
| "label": "t:sections.main-product.settings.image_zoom.options__1.label" | ||
| }, | ||
|
There was a problem hiding this comment. I guess this can be commented out or removed for now too 🤔 https://screenshot.click/03-58-akjn2-e2l2x.png There was a problem hiding this comment. I would say to keep it. It's okay if we're revisiting it soon. |
||
| { | ||
| "value": "none", | ||
| "label": "t:sections.main-product.settings.image_zoom.options__3.label" | ||
| } | ||
| ], | ||
| "default": "lightbox", | ||
| "label": "t:sections.main-product.settings.image_zoom.label" | ||
| }, | ||
| { | ||
| "type": "checkbox", | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be removing the translations too? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, we keep the translations. Similar to the dead code, it just makes our lives easier without causing any negatives.
The translation platform should have some memory of previous translations so that won't cause issues with time whenever we revisit it on the next release, BUT translation conflicts are a pain to deal with so let's just keep it there. There's not much negative in having some extra unused strings.