Change the link for "Enable filtering" #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanPJF
previously approved these changes
Dec 23, 2022
There was a problem hiding this comment.
FYI for other reviewers. This content is using a similar structure that we saw here when talking about review apps.
Which is shown in the same panel as this code change.
|
Looks like I need two approving reviews on this, going to assign to some more people as well. |
NathanPJF
approved these changes
Jan 4, 2023
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
* Change the link for "Enable filtering" * Update 15 translation files * Update 4 translation files * Update 1 translation file Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Filters are now edited in the Search & Discovery app. This changes the link so the user can learn how to customize filters via the app.
Why are these changes introduced?
Fixes https://github.com/Shopify/discovery-app/issues/1098
What approach did you take?
Copied/pasted text :D
Other considerations
Decision log
Visual impact on existing themes
They'll set an updated link: Video
Demo links
Checklist