[Quick add] Remove modal-dialog elements

[andrewetchen]

PR Summary

Potential solution to solve the problem of extra modal-dialog elements being added to the DOM / footer.

📌 This only happens when Pop-up blocks are added (screenshot)

• [Quick add] Product pop-up blocks added to DOM #2142

Why are these changes introduced?

Fixes #2142

What approach did you take?

Update quick-add.js

• I updated removeDOMElements() to also remove each modal-dialog element.

Testing steps/scenarios

• Make sure no extra modal-dialog elements get added when opening and closing the quick-add (choose options) modal

Demo links

• Editor (includes fix)
• Editor (Fresh copy of Dawn v7.0.1 to reproduce the bug):
  • It will appear when opening + closing the quick add "Choose options" modal from the homepage and collection page, but not from featured collection sections on the product page:

quick-add-choose-options-bug-summary.mp4

Checklist

• Added PR summary for release notes
• Requested review from UX (Only for changes that are affecting the experience or perceivable visual details)
• Created a ticket for the help.shopify.com documentation team about updates to theme settings. (Internal-only task)
• Followed theme code principles
• Linted with Theme Check
• Tested on mobile
• Tested on multiple browsers
• Tested for accessibility

[ludoboludo]

Tested and works as needed 👌
Thanks for creating the fix for this 😄

[sofiamatulis]

Works as expected but I cant reproduce the bug on main 🤔

Am I missing a step? https://screenshot.click/24-40-zdvn0-hwbr2.mp4

[andrewetchen]

Works as expected but I cant reproduce the bug on main 🤔

Am I missing a step? https://screenshot.click/24-40-zdvn0-hwbr2.mp4

Thanks for reviewing, Sofia!

*Edit

I'm having issues with our currently published / live Dawn theme on os2-demo. I've uploaded the latest version of Dawn v.7.0.1 (latest one from the Theme Store) and I'm able to reproduce when "Choosing options" from the home page and collection pages: https://os2-demo.myshopify.com/admin/themes/137476702230/editor

[sofiamatulis]

Paired with Andrew and for context this only seems to happen on the homepage: https://screenshot.click/24-30-5d2j3-602dj--8afa.mp4

Looks good 🎉