[Featured Collection] Update maximum products to 24

[LucasLacerdaUX]

PR Summary:

We updated the maximum amount of products displayed on the Featured Collection to be 24.

Why are these changes introduced?

Fixes #2093

What approach did you take?

Update the setting maximum value to 24.

Testing steps/scenarios

• Add a featured collection section to any page on your theme
• Change values from 13-24 and ensure they all look as expected on desktop
  • On mobile, test with both Enable swipe on mobile on and off

Demo links

• Store
• Editor

Checklist

• Added PR summary for release notes
• Requested review from UX (Only for changes that are affecting the experience or perceivable visual details)
• Created a ticket for the help.shopify.com documentation team about updates to theme settings. (Internal-only task)
• Followed theme code principles
• Linted with Theme Check
• Tested on mobile
• Tested on multiple browsers
• Tested for accessibility

[eugenekasimov]

Hey Lucas, everything works as expected. The only thing that looks odd to me now and it was even before this PR is the fact that on desktop 24 products never perfectly match 5 columns. It feels like it should be 25 products x 5 columns or 24 products x 4 or 6 columns. Otherwise it looks this way which feels wrong:

I know this is something about UX but I couldn't pass by :)

[sofiamatulis]

Works as expected 👍 I am curious about the decision as to why we are changing it 👀

[eugenekasimov]

I approve it now. But I still have the concern I mentioned above. I'll leave it for you and UX :)

[allylane]

@LucasLacerdaUX It is generally working as expected but I'm getting this error when I change settings, despite it having the intended effect when I make a change.

[allylane]

@eugenekasimov I think that's a good catch. Let's go with 25.

[eugenekasimov]

🚀

[sofiamatulis]

Works as expected 🎉

Do you mind sharing some context around this decision? 👀