-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide variant images setting #158
Merged
Merged
Changes from 16 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d007e4a
Show currently selected variant image only
ludoboludo 6cfb828
rebase part1
ludoboludo 702c71b
edit copy
ludoboludo a422119
change if statement order
ludoboludo d60a827
rebase part6
ludoboludo a02eb3b
rebase part8
ludoboludo 2163ff5
re add code tweaks to variant and slider in global.js
ludoboludo 69fcff7
add scrollLeft into setTimeout
ludoboludo 5d02205
address reviewer's feedback
ludoboludo 224dced
add timer into the onScroll function
ludoboludo 0b1a452
update modalContent selector
ludoboludo 409b004
address reviewer's comment and focus on adding functionality for the …
ludoboludo 87e4326
Update locales/en.default.schema.json
ludoboludo b3291eb
address reviewer's feedback
ludoboludo c09d46d
update the dispatchEvent
ludoboludo 6163377
remove code duplicate
ludoboludo dfefb32
fix modal selector
ludoboludo f7a7397
Update 10 translation files
translation-platform[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that this
modalContent
element is not the right one.#ProductModal-${this.dataset.section}
points to the external modal, not its content wrapper.This is causing the element to be prepended to the wrong container:

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯