Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust card badge visual tweaks #155

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Conversation

tauthomas01
Copy link
Contributor

Why are these changes introduced?

Fixes #25

The goal of this PR is to adjust the padding of the card badge

image

What approach did you take?

  • Adjust padding
  • Remove whitespacing on the card badge since it's using display: inline-block to fix this point:
  • remove the space characters that are added to the sale badge (it increases the padding left and right). Screenshot

Demo links

Checklist

Copy link
Contributor

@melissaperreault melissaperreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Thomas! LGTM! 🚢 🚢

Copy link
Contributor

@tyleralsbury tyleralsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - code and quick test. ✅

@ludoboludo ludoboludo self-requested a review July 12, 2021 20:16
@melissaperreault melissaperreault merged commit 81561cc into main Jul 13, 2021
@melissaperreault melissaperreault deleted the feature-badge-polish branch July 13, 2021 02:49
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sale badge on product cards: Visual tweaks
4 participants