Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS14 cart image bug #1410

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Fix iOS14 cart image bug #1410

merged 1 commit into from
Feb 25, 2022

Conversation

ludoboludo
Copy link
Contributor

@ludoboludo ludoboludo commented Feb 24, 2022

Why are these changes introduced?

Fixes #1409

What approach did you take?

Added an align-items: flex-start; property to prevent the image from stretching.

Other considerations

Testing steps/scenarios

  • Using browser stack and/or and iOS device running Safari version 14, go to the home page, click on a product (the dog one is a good example) from the feat. collection section, and add it to the cart. Then check the cart page and confirm that the image is using the right size. No weirdness.
  • Test in other browsers on desktop to make sure it didn't break any of the original layout/sizing.

Demo links
Please include a link to a demo store that includes preconfigured sections and settings to allow reviewers to easily test the features you are working on.

Checklist

@andrewetchen andrewetchen self-requested a review February 24, 2022 16:56
@sofiamatulis sofiamatulis self-assigned this Feb 24, 2022
Copy link
Contributor

@andrewetchen andrewetchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

  • Using browser stack and/or and iOS device running Safari version 14, go to the home page, click on a product (the dog one is a good example) from the feat. collection section, and add it to the cart. Then check the cart page and confirm that the image is using the right size. No weirdness.
  • Test in other browsers on desktop to make sure it didn't break any of the original layout/sizing.
    • Tested and working on desktop on Safari and Firefox 👍🏼

@gregjotau
Copy link

@ludoboludo can this be merged in? Since we only cherry pick commits from the main branch :)

@ludoboludo
Copy link
Contributor Author

@gregjotau just going to get another dev to review and should be merged by the end of the day 👍

Copy link
Contributor

@sofiamatulis sofiamatulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🎉

@ludoboludo ludoboludo merged commit 3f25b7a into main Feb 25, 2022
@ludoboludo ludoboludo deleted the ios14-cart-image-bug branch February 25, 2022 15:06
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On iOS 14 the cart image is stretched
4 participants