-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new icon options to the .json file #1128
Conversation
Adding new icon names and alternatives we are providing in a future release. Approach was to keep the icon options in alphabetical order.
I added the new icons. Two observations.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for providing each of them directly in a collapsible tab section! Very helpful 👍
Looks good to me, visually. Code looks good, at least as much as I can actually read of SVGs.
I used inspect element to check the viewbox and the positions of the icons within each viewbox looks good, and I also tested to ensure the slightly larger size didn't throw the collapsible content off, visually. Everything looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They all look good to me! Tested every icon on both sections with different color palettes and they're all ✅ :DD
* Adding new icon options to the .json file * Add icons to product and collapsed content settings Co-authored-by: martinamarien <martina.marien@shopify.com> Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: Tyler Alsbury <tyler.alsbury@shopify.com>
Adding new icon names and alternatives we are providing in a future release.
Approach was to keep the icon options in alphabetical order.
Why are these changes introduced?
We want to add flexibility to merchants.
Demo store Editor
What approach did you take?
Kept alphabetical order in the .json files, which means some icons have new placements in the array.