Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collage section product and collection card image size #1014

Merged
merged 45 commits into from
Dec 20, 2021
Merged

Fix collage section product and collection card image size #1014

Show file tree
Hide file tree
Changes from 42 commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
c84ec23
Add theme level grid setting (#885)
martinamarien Nov 16, 2021
30e1fed
Settings popup and drawer (#865)
sofiamatulis Nov 16, 2021
c8de760
Add media settings to non-card non-textbox elements (#893)
kmeleta Nov 16, 2021
8db278c
Text boxes global settings setup (#889)
tyleralsbury Nov 16, 2021
5614817
Add global sections settings (#891)
kmeleta Nov 16, 2021
0042541
Global settings - buttons, inputs (#844)
tyleralsbury Nov 16, 2021
eebeb66
Added back section settings tmeporarily (#899)
tyleralsbury Nov 17, 2021
cd7c227
Add global settings cards (#886)
KaichenWang Nov 17, 2021
84b60db
update secondary button background color (#903)
martinamarien Nov 17, 2021
aacaa8f
Clean up popup drawer feed (#902)
sofiamatulis Nov 18, 2021
9822e28
Revert global section settings (#911)
kmeleta Nov 18, 2021
1c340f4
Remove text box padding setting (#912)
kmeleta Nov 19, 2021
0fa8d3f
Image with text section - Apply global textbox and media settings (#918)
KaichenWang Nov 22, 2021
497d3b4
Split popup and drawer settings (#917)
kmeleta Nov 22, 2021
7e4043e
Update global setting range values (#954)
KaichenWang Dec 1, 2021
533b4ca
Fix section vertical spacing (#976)
KaichenWang Dec 10, 2021
770a8f6
Refactor collage
KaichenWang Dec 13, 2021
c0e65a0
Update BEM for video modal
KaichenWang Dec 13, 2021
15c4909
Adjust image spacing for mobile
KaichenWang Dec 13, 2021
a6942e2
Clean up
KaichenWang Dec 13, 2021
38a7b12
Set grip gap to global setting values
KaichenWang Dec 13, 2021
1dbacd7
Fix collage focus states
KaichenWang Dec 13, 2021
3a81f19
Revert block order in liquid
KaichenWang Dec 13, 2021
784a1d7
Revert block order in liquid
KaichenWang Dec 13, 2021
b050742
Update file name
KaichenWang Dec 13, 2021
df75f47
Add special case for single product/collection card
KaichenWang Dec 13, 2021
00ae69e
Remove ratios
KaichenWang Dec 13, 2021
1c04fc6
Remove single video case
KaichenWang Dec 13, 2021
bf8f8c1
Update auto height setting for product and collection cards
KaichenWang Dec 13, 2021
e87372d
Move card shadow to pseudo element (#1012)
kmeleta Dec 14, 2021
3e77c4b
Move product/card media shadows to pseudo element (#1013)
kmeleta Dec 14, 2021
8c0b185
Add variant pills settings (#1005)
martinamarien Dec 14, 2021
9e7496f
Image with text border/corner/shadow updates (#1003)
kmeleta Dec 14, 2021
6e8feed
Clean up
KaichenWang Dec 15, 2021
3dbb5b5
Merge branch 'all-global-settings' of https://github.com/Shopify/dawn…
KaichenWang Dec 15, 2021
e041722
Adjust implementation for card height extend
KaichenWang Dec 15, 2021
2c1bdb8
Adjust implementation for card height extend
KaichenWang Dec 15, 2021
46f3ca9
Fix focus and clickable area for video which includes padding
KaichenWang Dec 16, 2021
ffe1c0b
Merge branch 'all-global-settings' of https://github.com/Shopify/dawn…
KaichenWang Dec 17, 2021
6865794
Address PR comment. Fix 2 item mobile collage
KaichenWang Dec 17, 2021
f717bce
Add position relative to collage-card for shadows
KaichenWang Dec 17, 2021
2e82bef
Merge branch 'all-global-settings' of https://github.com/Shopify/dawn…
KaichenWang Dec 17, 2021
210382b
Merge branch 'all-global-settings' of https://github.com/Shopify/dawn…
KaichenWang Dec 17, 2021
44485c5
Update mobile collage layout
KaichenWang Dec 20, 2021
0c55ee5
Use minmax to prevent grid expansion beyond viewport
KaichenWang Dec 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading