Skip to content

Commit

Permalink
Tweak the image_url size to be the max value where necessary (#2110)
Browse files Browse the repository at this point in the history
* Tweak the image_url size to be the max value where necessary

* fix sizing in the header.
  • Loading branch information
ludoboludo authored Nov 17, 2022
1 parent c337301 commit 8ab8e61
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions sections/header.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@
{%- if section.settings.logo != blank -%}
{%- assign logo_alt = section.settings.logo.alt | default: shop.name | escape -%}
{%- assign logo_height = section.settings.logo_width | divided_by: section.settings.logo.aspect_ratio -%}
{{ section.settings.logo | image_url: width: section.settings.width | image_tag:
{{ section.settings.logo | image_url: width: 500 | image_tag:
class: 'header__heading-logo',
widths: '50, 100, 150, 200, 250, 300, 400, 500',
height: logo_height,
Expand Down Expand Up @@ -500,7 +500,7 @@
{%- if section.settings.logo != blank -%}
{%- assign logo_alt = section.settings.logo.alt | default: shop.name | escape -%}
{%- assign logo_height = section.settings.logo_width | divided_by: section.settings.logo.aspect_ratio -%}
{{ section.settings.logo | image_url: width: section.settings.width | image_tag:
{{ section.settings.logo | image_url: width: 500 | image_tag:
class: 'header__heading-logo',
widths: '50, 100, 150, 200, 250, 300, 400, 500',
height: logo_height,
Expand Down
4 changes: 2 additions & 2 deletions sections/image-banner.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
assign sizes = "100vw"
endif
-%}
{{ section.settings.image | image_url: width: 1500 | image_tag:
{{ section.settings.image | image_url: width: 3840 | image_tag:
loading: 'lazy',
width: section.settings.image.width,
height: image_height,
Expand Down Expand Up @@ -75,7 +75,7 @@
assign sizes = "100vw"
endif
-%}
{{ section.settings.image_2 | image_url: width: 1500 | image_tag:
{{ section.settings.image_2 | image_url: width: 3840 | image_tag:
loading: 'lazy',
width: section.settings.image_2.width,
height: image_height_2,
Expand Down
2 changes: 1 addition & 1 deletion sections/main-password-header.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
{%- if section.settings.logo != blank -%}
{%- assign logo_alt = section.settings.logo.alt | default: shop.name | escape -%}
{%- assign logo_height = section.settings.logo_max_width | divided_by: section.settings.logo.aspect_ratio -%}
{{ section.settings.logo | image_url: width: section.settings.logo.width | image_tag:
{{ section.settings.logo | image_url: width: 500 | image_tag:
class: 'password-logo',
widths: '50, 100, 150, 200, 250, 300, 400, 500',
width: section.settings.logo_max_width,
Expand Down

0 comments on commit 8ab8e61

Please sign in to comment.