Skip to content

Commit

Permalink
PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
@lgunn4
lgunn4 committed May 21, 2024
1 parent 5037c22 commit 47c336f
Show file tree
Hide file tree
Showing 4 changed files with 46 additions and 46 deletions.
2 changes: 1 addition & 1 deletion sections/featured-product.liquid
View file
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
<span>{{ 'products.product.volume_pricing.note' | t }}</span>
</div>
{%- endif -%}
{%- if cart.taxes_included or cart.duties_included or shop.shipping_policy.body != blank -%}
{%- if cart.taxes_included or cart.duties_included or shop.shipping_policy.body != blank -%}
<div class="product__tax caption rte">
{%- if cart.duties_included and cart.taxes_included -%}
{{ 'products.product.duties_and_taxes_included' | t }}
Expand Down
30 changes: 15 additions & 15 deletions sections/main-cart-footer.liquid
View file
Original file line number Diff line number Diff line change
Expand Up @@ -64,29 +64,29 @@
</div>

<small class="tax-note caption-large rte">
{%- if cart.duties_included == true and cart.taxes_included == true -%}
{%- if shop.shipping_policy.body != blank -%}
{{ 'sections.cart.duties_and_taxes_included_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url}}
{%- else -%}
{%- if cart.duties_included and cart.taxes_included -%}

Check warning on line 67 in sections/main-cart-footer.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

sections/main-cart-footer.liquid#L67 

[LiquidTag] Use {% liquid ... %} to write multiple tags
{%- if shop.shipping_policy.body == blank -%}
{{ 'sections.cart.duties_and_taxes_included_shipping_at_checkout_without_policy' | t }}
{%- endif -%}
{%- elsif cart.duties_included == false and cart.taxes_included == true -%}
{%- if shop.shipping_policy.body != blank -%}
{{ 'sections.cart.taxes_included_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url }}
{%- else -%}
{{ 'sections.cart.taxes_included_shipping_at_checkout_without_policy' | t }}
{{ 'sections.cart.duties_and_taxes_included_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url }}
{%- endif -%}
{%- elsif cart.duties_included == true and cart.taxes_included == false -%}
{%- if shop.shipping_policy.body != blank -%}
{{ 'sections.cart.duties_included_taxes_at_checkout_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url}}
{%- elsif cart.duties_included == false and cart.taxes_included -%}
{%- if shop.shipping_policy.body == blank -%}
{{ 'sections.cart.taxes_included_shipping_at_checkout_without_policy' | t }}
{%- else -%}
{{ 'sections.cart.taxes_included_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url }}
{%- endif -%}
{%- elsif cart.duties_included and cart.taxes_included == false -%}
{%- if shop.shipping_policy.body == blank -%}
{{ 'sections.cart.duties_included_taxes_at_checkout_shipping_at_checkout_without_policy' | t }}
{%- else -%}
{{ 'sections.cart.duties_included_taxes_at_checkout_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url }}
{%- endif -%}
{%- elsif cart.duties_included == false and cart.taxes_included == false -%}
{%- if shop.shipping_policy.body != blank -%}
{{ 'sections.cart.taxes_at_checkout_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url }}
{%- else -%}
{%- if shop.shipping_policy.body == blank -%}
{{ 'sections.cart.taxes_at_checkout_shipping_at_checkout_without_policy' | t }}
{%- else -%}
{{ 'sections.cart.taxes_at_checkout_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url }}
{%- endif -%}
{%- endif -%}
</small>
Expand Down
30 changes: 15 additions & 15 deletions snippets/cart-drawer.liquid
View file
Original file line number Diff line number Diff line change
Expand Up @@ -493,29 +493,29 @@
</div>

<small class="tax-note caption-large rte">
{%- if cart.duties_included == true and cart.taxes_included == true -%}
{%- if shop.shipping_policy.body != blank -%}
{{ 'sections.cart.duties_and_taxes_included_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url}}
{%- else -%}
{%- if cart.duties_included and cart.taxes_included -%}

Check warning on line 496 in snippets/cart-drawer.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

snippets/cart-drawer.liquid#L496 

[LiquidTag] Use {% liquid ... %} to write multiple tags
{%- if shop.shipping_policy.body == blank -%}
{{ 'sections.cart.duties_and_taxes_included_shipping_at_checkout_without_policy' | t }}
{%- endif -%}
{%- elsif cart.duties_included == false and cart.taxes_included == true -%}
{%- if shop.shipping_policy.body != blank -%}
{{ 'sections.cart.taxes_included_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url }}
{%- else -%}
{{ 'sections.cart.taxes_included_shipping_at_checkout_without_policy' | t }}
{{ 'sections.cart.duties_and_taxes_included_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url }}
{%- endif -%}
{%- elsif cart.duties_included == true and cart.taxes_included == false -%}
{%- if shop.shipping_policy.body != blank -%}
{{ 'sections.cart.duties_included_taxes_at_checkout_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url}}
{%- elsif cart.duties_included == false and cart.taxes_included -%}
{%- if shop.shipping_policy.body == blank -%}
{{ 'sections.cart.taxes_included_shipping_at_checkout_without_policy' | t }}
{%- else -%}
{{ 'sections.cart.taxes_included_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url }}
{%- endif -%}
{%- elsif cart.duties_included and cart.taxes_included == false -%}
{%- if shop.shipping_policy.body == blank -%}
{{ 'sections.cart.duties_included_taxes_at_checkout_shipping_at_checkout_without_policy' | t }}
{%- else -%}
{{ 'sections.cart.duties_included_taxes_at_checkout_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url }}
{%- endif -%}
{%- elsif cart.duties_included == false and cart.taxes_included == false -%}
{%- if shop.shipping_policy.body != blank -%}
{{ 'sections.cart.taxes_at_checkout_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url }}
{%- else -%}
{%- if shop.shipping_policy.body == blank -%}
{{ 'sections.cart.taxes_at_checkout_shipping_at_checkout_without_policy' | t }}
{%- else -%}
{{ 'sections.cart.taxes_at_checkout_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url }}
{%- endif -%}
{%- endif -%}
</small>
Expand Down
30 changes: 15 additions & 15 deletions snippets/quick-order-list.liquid
View file
Original file line number Diff line number Diff line change
Expand Up @@ -161,29 +161,29 @@
<p class="totals__subtotal h5">{{ 'sections.quick_order_list.product_total' | t }}</p>
</div>
<small class="tax-note caption-large rte">
{%- if cart.duties_included == true and cart.taxes_included == true -%}
{%- if shop.shipping_policy.body != blank -%}
{{ 'sections.cart.duties_and_taxes_included_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url}}
{%- else -%}
{%- if cart.duties_included and cart.taxes_included -%}

Check warning on line 164 in snippets/quick-order-list.liquid

View workflow job for this annotation

GitHub Actions / Theme Check Report

snippets/quick-order-list.liquid#L164 

[LiquidTag] Use {% liquid ... %} to write multiple tags
{%- if shop.shipping_policy.body == blank -%}
{{ 'sections.cart.duties_and_taxes_included_shipping_at_checkout_without_policy' | t }}
{%- endif -%}
{%- elsif cart.duties_included == false and cart.taxes_included == true -%}
{%- if shop.shipping_policy.body != blank -%}
{{ 'sections.cart.taxes_included_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url }}
{%- else -%}
{{ 'sections.cart.taxes_included_shipping_at_checkout_without_policy' | t }}
{{ 'sections.cart.duties_and_taxes_included_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url }}
{%- endif -%}
{%- elsif cart.duties_included == true and cart.taxes_included == false -%}
{%- if shop.shipping_policy.body != blank -%}
{{ 'sections.cart.duties_included_taxes_at_checkout_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url}}
{%- elsif cart.duties_included == false and cart.taxes_included -%}
{%- if shop.shipping_policy.body == blank -%}
{{ 'sections.cart.taxes_included_shipping_at_checkout_without_policy' | t }}
{%- else -%}
{{ 'sections.cart.taxes_included_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url }}
{%- endif -%}
{%- elsif cart.duties_included and cart.taxes_included == false -%}
{%- if shop.shipping_policy.body == blank -%}
{{ 'sections.cart.duties_included_taxes_at_checkout_shipping_at_checkout_without_policy' | t }}
{%- else -%}
{{ 'sections.cart.duties_included_taxes_at_checkout_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url }}
{%- endif -%}
{%- elsif cart.duties_included == false and cart.taxes_included == false -%}
{%- if shop.shipping_policy.body != blank -%}
{{ 'sections.cart.taxes_at_checkout_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url }}
{%- else -%}
{%- if shop.shipping_policy.body == blank -%}
{{ 'sections.cart.taxes_at_checkout_shipping_at_checkout_without_policy' | t }}
{%- else -%}
{{ 'sections.cart.taxes_at_checkout_shipping_at_checkout_with_policy_html' | t: link: shop.shipping_policy.url }}
{%- endif -%}
{%- endif -%}
</small>
Expand Down

0 comments on commit 47c336f

Please sign in to comment.