This repository has been archived by the owner on Mar 7, 2018. It is now read-only.
add error string when widget not rendered #308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the cryptic ruby raw string being printed if no rendering template were found. Closes: #307
|
This issue affects me often as well while my team evaluates Dashing. We are thinking of exposing dashing to much wider dev audience to create their own widgets, so avoiding this cryptic string is going to be very important if we adopt dashing as our solution for dashboards! |
|
This is nice -- error handling ftw. 👍 to merge. |
|
Can this be merged? |
|
Moved to here: |
|
OK closing this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the cryptic ruby raw string being printed if no rendering
template were found.
Closes: #307