Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump theme check packages #5511

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Conversation

aswamy
Copy link
Contributor

@aswamy aswamy commented Mar 12, 2025

Ideally the final piece of fixing the CLI for Windows platform

Part of #3497
Previous PR: Shopify/theme-tools#835

WHY are these changes introduced?

  • Bumping theme check packages so that it can theme check on windows

WHAT is this pull request doing?

  • n/a

How to test your changes?

  • install the snapshot on a windows system (i.e. npm i -g @shopify/cli@0.0.0-snapshot-20250312183234)
  • run shopify theme check on a theme on the windows system
  • see theme check errors

BEFORE
image

AFTER (Powershell)
image

AFTER (cmd)
image

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@aswamy
Copy link
Contributor Author

aswamy commented Mar 12, 2025

/snapit

Copy link
Contributor

🫰✨ Thanks @aswamy! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/cli@0.0.0-snapshot-20250312183234

Tip

If you get an ETARGET error, install it with NPM and the flag --@shopify:registry=https://registry.npmjs.org

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
76.54% (-0.01% 🔻)
9316/12171
🟡 Branches 71.8% 4570/6365
🟡 Functions 76.17% 2423/3181
🟡 Lines 77.09% 8802/11418
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
96.39% (-1.2% 🔻)
88.57% 95.45% 100%
🟢
... / ConcurrentOutput.tsx
98.36% (-1.64% 🔻)
88% (-4% 🔻)
100%
98.33% (-1.67% 🔻)

Test suite run success

2115 tests passing in 931 suites.

Report generated by 🧪jest coverage report action from 9f3c958

@aswamy aswamy requested a review from EvilGenius13 March 12, 2025 18:44
@aswamy aswamy marked this pull request as ready for review March 12, 2025 18:44
@aswamy aswamy requested review from a team as code owners March 12, 2025 18:44
Copy link
Contributor

@EvilGenius13 EvilGenius13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 the snap build for theme check and it's working on my windows machine. Awesome work!

@aswamy aswamy added this pull request to the merge queue Mar 12, 2025
Merged via the queue into main with commit db9cbf3 Mar 12, 2025
29 checks passed
@aswamy aswamy deleted the bump-theme-check-packages-2025-03-12 branch March 12, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants